Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix #681

Merged
merged 4 commits into from
Sep 4, 2024
Merged

bug fix #681

merged 4 commits into from
Sep 4, 2024

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Sep 4, 2024

No description provided.

Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.29%. Comparing base (6233b28) to head (10c1604).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/eni/crdv2.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #681      +/-   ##
==========================================
+ Coverage   27.98%   29.29%   +1.31%     
==========================================
  Files          78       79       +1     
  Lines        8565     8584      +19     
==========================================
+ Hits         2397     2515     +118     
+ Misses       5835     5730     -105     
- Partials      333      339       +6     
Flag Coverage Δ
unittests 29.29% <80.00%> (+1.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@l1b0k l1b0k force-pushed the main branch 2 times, most recently from 9d140da to f61c8ba Compare September 4, 2024 07:51
Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
@BSWANG BSWANG merged commit ed121a8 into AliyunContainerService:main Sep 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants